Public Release for Fall24 meta-release #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change version to v1.0.0
Fix links for test definition
Fix links for test definition
Prepare API Checklist for sim swap subscription
Update readme for r1.2
Making aligned with other readme
update changelog for r1.2
update changelog
fix duplicate swap
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
fernandopradocabrillo
previously approved these changes
Aug 23, 2024
hdamker
reviewed
Aug 23, 2024
documentation/API_documentation/sim-swap-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/sim-swap-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/sim-swap-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
…diness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
…diness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
…diness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
|
Huge thanks @hdamker for the review. |
13 tasks
Make linting happy
update name of the feature files
jlurien
suggested changes
Sep 3, 2024
|
|
||
| Get timestamp of last MSISDN <-> IMSI pairing change for the provided phone number. | ||
| # | ||
| # Get timestamp of last MSISDN <-> IMSI pairing change for the provided phone number. | ||
|
|
||
| Background: Common retrieveSimSwapDate setup | ||
| Given the resource "sim-swap/v0/retrieve-date" |
|
|
||
| check if SIM swap has been performed during a past period | ||
| # | ||
| # check if SIM swap has been performed during a past period | ||
|
|
||
| Background: Common checkSimSwap setup | ||
| Given the resource "sim-swap/v0/check" |
documentation/API_documentation/sim-swap-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…diness-Checklist.md Co-authored-by: Jose Luis Urien <[email protected]>
Change sim-swap/v0/check to sim-swap/v1/check
Change sim-swap/v0/retrieve-date to sim-swap/v1/retrieve-date
Chenge /sim-swap-subscriptions/v0/subscriptions to /sim-swap-subscriptions/v0.1/subscriptions
|
@jlurien Thanks for the review. Update done for the 3 files. |
|
Let's wait to decision on camaraproject/ReleaseManagement#89 to merge this |
|
Please see camaraproject/ReleaseManagement#89 on how to update the Test result statement in the API readiness checklist for this Fall24 meta-release. |
Taking care of the Test result statement accordingly to camaraproject/ReleaseManagement#89
|
@jlurien @tanjadegroot aligned for the Test Statement. |
jlurien
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Release PR approved (on behalf of Release Management)
PR can now be merged and release r1.2 created. Please update https://wiki.camaraproject.org/display/CAM/SimSwap+API+Release+Tracking with date for M4 and link to r1.2 when it is created. Thanks
|
Thanks @jlurien for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Related to issue #109
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Missing link for Test Statement for sim-swap
Changelog input
Additional documentation
This section can be blank.